Fix: segfault of matmul with transpose#37
Merged
austinvhuang merged 2 commits intoAnswerDotAI:mainfrom Aug 2, 2024
Merged
Conversation
…egfault is resolved" This reverts commit a536c8f.
Contributor
|
Thanks, works on my end! On my MBP M1 Max, the difference between 7 & 9 is probably within statistical error of each other (~ 2.54-2.57 TFLOPS for both), at least at the current time. |
Collaborator
Author
|
Thank you for checking it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes #35 to fix segfault.
The following points have been fixed:
1, Use getenv value immediately
2, Change the returned type of versionToStr to std::string, because lldb stoped at logger with versionToStr.